TinTin++ Mud Client The TinTin++ message board

 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
TinTin++ Mud Client

#showme leaves blank line in buffer

 
Post new topic   Reply to topic    The TinTin++ message board Forum Index -> Bug Reports
View previous topic :: View next topic  
Author Message
pfn



Joined: 12 May 2006
Posts: 13

PostPosted: Tue Jul 18, 2006 11:23 am    Post subject: #showme leaves blank line in buffer Reply with quote

Any time I do a "#showme text ..." in an action, I always get a blank line after the showme text when I examine the buffer.

Why? It does not occur during normal scroll, only when scrolling up in the buffer or saving the buffer.

This occurs whether or not I have #gagline, so #showme must be appending a blank line in the buffer?
Back to top
View user's profile Send private message
Scandum
Site Admin


Joined: 03 Dec 2004
Posts: 3796

PostPosted: Tue Jul 18, 2006 5:52 pm    Post subject: Reply with quote

Looks like an issue indeed, I'll look into it.
Back to top
View user's profile Send private message Send e-mail
pfn



Joined: 12 May 2006
Posts: 13

PostPosted: Wed Jul 19, 2006 1:15 pm    Post subject: Reply with quote

If you fix this and don't plan on releasing a .1 any time soon, can you post a diff so that we can patch manually if necessary?

Thanks.
Back to top
View user's profile Send private message
Scandum
Site Admin


Joined: 03 Dec 2004
Posts: 3796

PostPosted: Thu Jul 20, 2006 6:34 am    Post subject: Reply with quote

Fixed the problem which was with some experimental code.

The latest unofficial update is available at:

http://www.scandum.com/tintin/download/tintin.tar.gz
Back to top
View user's profile Send private message Send e-mail
pfn



Joined: 12 May 2006
Posts: 13

PostPosted: Fri Jul 21, 2006 2:27 pm    Post subject: Reply with quote

Thanks,

For those that don't want the entire change/download the entire thing, I believe you can just apply the following diff:

Code:

diff -ur tt/src/misc.c tt-FIXED/src/misc.c
--- tt/src/misc.c       2006-04-22 14:41:46.000000000 -0700
+++ tt-FIXED/src/misc.c 2006-07-20 04:24:15.000000000 -0700
@@ -338,7 +338,7 @@
        }
        do_one_line(left, ses);

-       substitute(ses, left, temp, SUB_COL|SUB_ESC|SUB_EOL);
+       substitute(ses, left, temp, SUB_COL|SUB_ESC);

        if (HAS_BIT(ses->flags, SES_FLAG_GAG))
        {
@@ -363,11 +363,11 @@
                goto_rowcol(ses, ses->bot_row, 1);
        }

-       sprintf(output, "\033[0m\033[0K%s\033[0m", temp);
+       sprintf(output, "\033[0m%s\033[0m", temp);

        add_line_buffer(ses, output, FALSE);

-       printline(ses, output, TRUE);
+       printline(ses, output, FALSE);

        if (!HAS_BIT(ses->flags, SES_FLAG_READMUD) && IS_SPLIT(ses))
        {
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    The TinTin++ message board Forum Index -> Bug Reports All times are GMT - 5 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
Get TinTin++ Mud Client at SourceForge.net. Fast, secure and Free Open Source software downloads Get TinTin++ Mud Client at SourceForge.net. Fast, secure and Free Open Source software downloads
TinTin++ Homepage

Powered by phpBB © 2001, 2002 phpBB Group