TinTin++ Mud Client The TinTin++ message board

 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
TinTin++ Mud Client

#line log broken with 2.00.9

 
Post new topic   Reply to topic    The TinTin++ message board Forum Index -> Bug Reports
View previous topic :: View next topic  
Author Message
grimm



Joined: 13 Jun 2005
Posts: 31

PostPosted: Wed Feb 20, 2013 3:16 pm    Post subject: #line log broken with 2.00.9 Reply with quote

Code:
#action {^%w tells you} {#line log logs/comms.log}


That worked fine in 2.00.8 . I upgraded to 2.00.9 today and it logs blank lines.
Back to top
View user's profile Send private message
Scandum
Site Admin


Joined: 03 Dec 2004
Posts: 3796

PostPosted: Wed Feb 20, 2013 6:08 pm    Post subject: Reply with quote

I did some work on logging and I guess I broke it. I'll look into it.
Back to top
View user's profile Send private message Send e-mail
Slysven



Joined: 10 Apr 2011
Posts: 365
Location: As "Jomin al'Bara" in WoTMUD or Wiltshire, UK

PostPosted: Wed Feb 20, 2013 9:18 pm    Post subject: Reply with quote

Pardon me for butting in but will this change work for you?
Code:
#action {^%w tells you} {#line log logs/comms.log %0}
I see from the manual that %0 is supposed to be used if nothing is specified, but as Mr Scandum says he has been doing some tweaking in the log code!
Back to top
View user's profile Send private message
Biologic



Joined: 06 Dec 2007
Posts: 15

PostPosted: Sun Feb 24, 2013 11:17 am    Post subject: Reply with quote

I came in to report the same issue (#line log no longer working). Specifically, I compiled 2.00.9 on Mac OS X 10.8.2 after installing pcre-lib.

Example:
#action {says} {#line log test.log}
#alias {test} {#show Bob says 'hi'}
test
Bob says 'hi'

results in a file test.log with a single blank line. Subsequent usage of the 'test' alias adds a new blank line every time.

Changing it to #action {says} {#line log test.log %0}

results in a file test.log with the single word 'says'.
Back to top
View user's profile Send private message
Slysven



Joined: 10 Apr 2011
Posts: 365
Location: As "Jomin al'Bara" in WoTMUD or Wiltshire, UK

PostPosted: Mon Feb 25, 2013 4:37 pm    Post subject: Reply with quote

Humm, there has been some stuff going on in that area ( DO_LINE(line_log) & DO_LINE(line_logverbatim) ) in line.c file. I can't quite put my finger on it so lets hope Mr Scandum comes up with a fix. Coffee

In passing I would note that logging with the SES_FLAG_LOGHTML flag set (#CONFIG {LOG} {HTML}) this things <i>STILL</i> do not close the HTML written out, they leave a number of tags opened by the write_html_header() function such that there will be errors that an HTML validator will "throw a wobbly" about, I bodged a solution that fixes this with a write_html_trailer() but it is not up to production strength yet and is complicated that what it writes has to be <i>un</i>-written before any file can be appended to, which, for a log file, is very likely to happen... Cool
Back to top
View user's profile Send private message
grimm



Joined: 13 Jun 2005
Posts: 31

PostPosted: Fri Mar 01, 2013 10:38 pm    Post subject: Reply with quote

Slysven wrote:
Pardon me for butting in but will this change work for you?
Code:
#action {^%w tells you} {#line log logs/comms.log %0}
I see from the manual that %0 is supposed to be used if nothing is specified, but as Mr Scandum says he has been doing some tweaking in the log code!

I actually am doing that now, but it keeps none of the formatting from the mud (colors).
Back to top
View user's profile Send private message
Slysven



Joined: 10 Apr 2011
Posts: 365
Location: As "Jomin al'Bara" in WoTMUD or Wiltshire, UK

PostPosted: Sat Mar 02, 2013 11:33 am    Post subject: Reply with quote

grimm wrote:
I actually am doing that now, but it keeps none of the formatting from the mud (colors).


Humm, as a test does the '~' prefix to the #ACTION trigger string change that?
Code:
#action {~^%w tells you} {#line log logs/comms.log %0}
You'll need to find the exact ANSI ESC sequence to put between the '^' and the '%w' because we are now explicitly checking the color sequences and it won't fire otherwise and it'd be unsafe to put a wild-card match there (otherwise you can fall victim to "Bob says: 'Alice tells you: you are an x#!%...!'" type issues)...
Back to top
View user's profile Send private message
Biologic



Joined: 06 Dec 2007
Posts: 15

PostPosted: Sat Mar 09, 2013 10:43 pm    Post subject: Reply with quote

Fixed in the 2.01.0 beta.
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    The TinTin++ message board Forum Index -> Bug Reports All times are GMT - 5 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
Get TinTin++ Mud Client at SourceForge.net. Fast, secure and Free Open Source software downloads Get TinTin++ Mud Client at SourceForge.net. Fast, secure and Free Open Source software downloads
TinTin++ Homepage

Powered by phpBB © 2001, 2002 phpBB Group