TinTin++ Mud Client The TinTin++ message board

 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 
TinTin++ Mud Client

Repeated prompts (not using #prompt)

 
Post new topic   Reply to topic    The TinTin++ message board Forum Index -> Bug Reports
View previous topic :: View next topic  
Author Message
moebius



Joined: 27 Jan 2005
Posts: 96

PostPosted: Tue May 06, 2008 12:16 pm    Post subject: Repeated prompts (not using #prompt) Reply with quote

Upgraded to 1.98.1 today (first upgrade in a long while) and noticed an issue with how the prompt is displayed. When multiple prompts are displayed on the same line (from issuing a number of commands at once), they are repeated more times that should happen.

For example:

Code:
> #5 cast 'invis' me
Ok.
Nothing new seems to happen.

699Ma> 699Ma> 699Ma| > 699Ma> 699Ma> 699Ma| > 699Ma| > 699Ma> 699Ma> 699Ma| >
699Ma> 699Ma> 699Ma| > 699Ma| > 699Ma| > 699Ma| >


There should only be 5 prompts displayed, one for each cast command. Compare with the output from the equivalent raw telnet:

Code:
> cast 'invis' me
cast 'invis' me
cast 'invis' me
cast 'invis' me
cast 'invis' me
Ok.
Nothing new seems to happen.

408Ma> 408Ma| > 408Ma| > 408Ma| > 408Ma| > Ok.
Nothing new seems to happen.


This prompt spam seems to be multiplied exponentially, especially if they fill more than one line. For example, here is the output of an alias I have to cast 11 common buffs on myself:

Code:

You feel a tingling sensation.

634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| >
634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| >
634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma>
634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma|
634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| >
634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma>
634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma|
> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma> 634Ma>
634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma>
634Ma> 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| >
634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| >
634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma>
634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma|
> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma> 634Ma>
634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma>
634Ma> 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| >
634Ma| > 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma|
> 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma| > 634Ma> 634Ma>
634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma>
634Ma| > 634Ma| > 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma|
> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma| >
634Ma> 634Ma> 634Ma| > 634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma> 634Ma> 634Ma| >
634Ma> 634Ma> 634Ma| > 634Ma| > 634Ma| > 634Ma| > 634Ma| > 634Ma| > Ok.
You feel someone protecting you.

624Ma| > 624Ma| > 624Ma| > 624Ma| > 624Ma| > 624Ma| > 624Ma| > 624Ma| > 624Ma| >
624Ma| > 624Ma| > 624Ma| > 624Ma| > 624Ma| > 624Ma| > Ok.
Your eyes tingle.

614Ma| > Ok.

637Ma| > You lost your concentration!

635Ma| > 635Ma| > 635Ma| > You lost your concentration!

625Ma| > 625Ma| > 625Ma| > No-one around by that name.

625Ma| > Ok.
Too much air already..

600Ma| > Ok.
Too much air already..


I am running tintin++ in gnome-terminal, TERM=linux, on Ubuntu 7.10 (Gutsy Gibbon).
_________________
StrangeMUD - strangemud.net:9332
Back to top
View user's profile Send private message
Scandum
Site Admin


Joined: 03 Dec 2004
Posts: 3796

PostPosted: Sun May 11, 2008 8:33 pm    Post subject: Reply with quote

I assume you use #split but not #prompt?

I'll look into it regardless.
Back to top
View user's profile Send private message Send e-mail
moebius



Joined: 27 Jan 2005
Posts: 96

PostPosted: Wed May 14, 2008 10:36 pm    Post subject: Reply with quote

Scandum wrote:
I assume you use #split but not #prompt?

I'll look into it regardless.


That is correct.
_________________
StrangeMUD - strangemud.net:9332
Back to top
View user's profile Send private message
Scandum
Site Admin


Joined: 03 Dec 2004
Posts: 3796

PostPosted: Tue May 27, 2008 2:20 pm    Post subject: Reply with quote

I fixed it for the next release.
Back to top
View user's profile Send private message Send e-mail
wont



Joined: 23 May 2008
Posts: 13

PostPosted: Thu May 29, 2008 5:51 pm    Post subject: Reply with quote

I get weird behaviour when running tt++ in screen (screen the screen manager program).

alt+f doesn't work, End key sometimes doesn't work. I haven't been able to reproduce it exactly, but sometimes the word order in the current line is messed up.

This won't happen when I run it outside screen.
Back to top
View user's profile Send private message
Scandum
Site Admin


Joined: 03 Dec 2004
Posts: 3796

PostPosted: Fri May 30, 2008 10:17 am    Post subject: Reply with quote

cursor.c row 750 should be changed to:

input_printf("\033[%dC", gtd->input_cur - index_cur);

That should get alt-f working on all systems.


I'll look into the other stuff if you figure out how to reproduce it.
Back to top
View user's profile Send private message Send e-mail
wont



Joined: 23 May 2008
Posts: 13

PostPosted: Fri May 30, 2008 12:16 pm    Post subject: Reply with quote

Thanks, this fixes it. However, consider the following enhancement:
Code:

/* add this while loop */
        while (gtd->input_cur < gtd->input_len && gtd->input_buf[gtd->input_cur] == ' ')
        {
                gtd->input_cur++;
                gtd->input_pos++;
        }

        input_printf("\033[%dC", gtd->input_cur - index_cur);

It'll make the cursor jump to the beginning of the following word, not the start of the whitespace. This is consistent with how my readline behaves.


One more bug I found:
when searching around in old commands with control-r, it has become impossible to select the commands with up/down arrow keys.

Also, I have no idea how/why I reported the bug in this thread (=[/code][/quote]
Back to top
View user's profile Send private message
Scandum
Site Admin


Joined: 03 Dec 2004
Posts: 3796

PostPosted: Fri May 30, 2008 3:41 pm    Post subject: Reply with quote

wont wrote:
It'll make the cursor jump to the beginning of the following word, not the start of the whitespace. This is consistent with how my readline behaves.

Not consistent however with how readline behaves on cygwin and slackware.

Perhaps the following would do the trick for you: #macro {\ef} {#cursor next word;#cursor next word;#cursor prev word}

wont wrote:

when searching around in old commands with control-r, it has become impossible to select the commands with up/down arrow keys.

Should work again in the next release, though it re-introduced a cosmetic bug.

wont wrote:

Also, I have no idea how/why I reported the bug in this thread (=

I wondered about that. Coffee
Back to top
View user's profile Send private message Send e-mail
Display posts from previous:   
Post new topic   Reply to topic    The TinTin++ message board Forum Index -> Bug Reports All times are GMT - 5 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum
Get TinTin++ Mud Client at SourceForge.net. Fast, secure and Free Open Source software downloads Get TinTin++ Mud Client at SourceForge.net. Fast, secure and Free Open Source software downloads
TinTin++ Homepage

Powered by phpBB © 2001, 2002 phpBB Group